Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: COREPACK_NPM_REGISTRY defaults to the regitry of npm #656

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: COREPACK_NPM_REGISTRY defaults to the regitry of npm #656

wants to merge 1 commit into from

Conversation

zanminkian
Copy link

Closes #540

aduh95
aduh95 requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm might not be on the path, we can't assume it's going to work this way. Also, it would introduce quite a heavy perf penalty to any corepack command, even those which have nothing to do with npm or its registry.

@zanminkian
Copy link
Author

I will look into it in these few days.

@zanminkian zanminkian marked this pull request as draft February 17, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: COREPACK_NPM_REGISTRY defaults to $(npm config get registry)
2 participants
@zanminkian @aduh95