Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow std::unordered_map as ObjectType #2956

Closed
wants to merge 4 commits into from
Closed

Allow std::unordered_map as ObjectType #2956

wants to merge 4 commits into from

Conversation

nlohmann
Copy link
Owner

This PR fixes the definition of object_t to allow to use std::unordered_map as ObjectType.

Fixes #2932.

@nlohmann nlohmann self-assigned this Aug 19, 2021
@nlohmann nlohmann marked this pull request as draft August 19, 2021 14:09
@nlohmann nlohmann mentioned this pull request Aug 20, 2021
Closed
@nlohmann nlohmann added the state: help needed the issue needs help to proceed label Aug 20, 2021
@nlohmann nlohmann closed this Sep 2, 2021
@nlohmann nlohmann deleted the issue2932 branch June 18, 2022 19:09
@edelmanjm
Copy link

Can I ask why this was closed?

@gregmarr
Copy link
Contributor

It wasn't possible to implement at the time. @nlohmann I wonder if the introduction of the intermediate data struct holding the value type means that it is possible to do this now, since the basic_json type could be complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nlohmann nlohmann

Labels
state: help needed the issue needs help to proceed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for unordered_map as object_t
3 participants
@nlohmann @edelmanjm @gregmarr