-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make assert configurable via JSON_ASSERT #2242
Conversation
It seems there is a memory issue - Valgrind and ASAN are complaining about the new test case. |
I think any |
I think I chose a bad function to test - one where a non-aborting assertion left a non-void function without return value. I now chose a different function where first an assertion fires and even if it does not abort an exception is thrown. |
(The test fails if exceptions are switched off...) |
🔖 Release itemThis issue/PR will be part of the next release of the library. This template helps preparing the release notes. Type
Description
|
This PR introduces a macro
JSON_ASSERT(x)
which defaults toassert(x)
, but can be replaced by any other implementation.Closes #2239.