Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport a test to see if timestamps are working in aarch64 #1837

Closed
wants to merge 3 commits into from

Conversation

pacak
Copy link
Contributor

@pacak pacak commented Oct 6, 2022

Don't merge, this MR is to run the CI to see if we are getting the same errors as in #1744

@rtzoeller
Copy link
Collaborator

bors try

bors bot added a commit that referenced this pull request Oct 8, 2022
@bors
Copy link
Contributor

bors bot commented Oct 8, 2022

try

Build failed:

@rtzoeller
Copy link
Collaborator

@pacak the test you're modifying currently builds for a few different platforms, but it looks like ScmTimestampns is only defined on Linux. You can ignore the failures on other platforms.

@rtzoeller
Copy link
Collaborator

Those checkout failures are odd though.

bors retry

bors bot added a commit that referenced this pull request Oct 8, 2022
@bors
Copy link
Contributor

bors bot commented Oct 8, 2022

try

Build failed:

@pacak
Copy link
Contributor Author

pacak commented Oct 8, 2022

The idea for this is to check if we can replicate the same problems on aarch64 as in #1744 so I'm only interested in one result - aarch64. Or you think it makes sense to merge
#1837 anyway?

@rtzoeller
Copy link
Collaborator

No, I wasn't suggesting merging this PR - I just was offering a suggestion to get rid of the other build failures to make it easier to parse the results.

@pacak
Copy link
Contributor Author

pacak commented Oct 8, 2022

If it's important - sure, I'll see what I can do

@rtzoeller
Copy link
Collaborator

This seems to be passing just fine on my aarch64 target. :/

@pacak
Copy link
Contributor Author

pacak commented Oct 13, 2022

This seems to be passing just fine on my aarch64 target. :/

🤔 and the new one still fails? I guess I'll go over the new branch one more time - maybe I'm doing something stupid and just managing to get away with it on non aarch64.

@rtzoeller
Copy link
Collaborator

This seems to be passing just fine on my aarch64 target. :/

thinking and the new one still fails? I guess I'll go over the new branch one more time - maybe I'm doing something stupid and just managing to get away with it on non aarch64.

I'm going to do another clean build against your new branch just to be sure.... just to make sure something didn't get screwed up during my uptaking of your latest changes. I'll let you know shortly.

@rtzoeller
Copy link
Collaborator

Yeah, confirmed the other branch (pacak/master) is still failing. Tested against the 5.19 kernel.

@rtzoeller
Copy link
Collaborator

Hmm, it looks like AWS Graviton has a free trial right now (with a fairly high compute limit, at least for this). I wonder if you'd be able to reproduce it there?

@pacak
Copy link
Contributor Author

pacak commented Oct 13, 2022

I wonder if you'd be able to reproduce it there?

Probably, need to figure out what to do with it first :)

@pacak pacak closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants