Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eva slurm grace cluster #852

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

maxibor
Copy link
Member

@maxibor maxibor commented Mar 4, 2025


name: New Config
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

@maxibor maxibor requested review from jfy133 and TCLamnidis March 4, 2025 11:07
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something has gone wrong here - you've got root params twice now rather than per cluster... and this would not necessarily work because evo genetics have their own 'half' of their old cluster and wouldn't necessarily be able to access some files.

Also we are now not promoting the use of profiles within a given config because of inheritance uncertainties when specifyuing the profile order, but rather having separate configs per cluster (see mpcdf_viper vs mpcdf) for example.

So I would recommend leave eva as is, and making a new config called eva_grace

@maxibor
Copy link
Member Author

maxibor commented Mar 6, 2025

Well spoted. That's what happends commiting just before lunch.
For the rest of the comments, the plan for the near future is to actually switch all hardware to grace. But as of now, the filysystem is already shared between the two clusters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants