MSSQL Multiple Instances (windows.plugin) #19559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
ilyam8
approved these changes
Feb 3, 2025
stelfrag
pushed a commit
to stelfrag/netdata
that referenced
this pull request
Feb 4, 2025
(cherry picked from commit 86a9690)
Merged
Ferroin
pushed a commit
that referenced
this pull request
Feb 4, 2025
(cherry picked from commit 86a9690)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move the variable inside the loop to reset its value before calling
RegEnumValueagain. Without this change, MSSQL data cannot be collected properly.Test Plan
Additional Information
For users: How does this change affect me?