Fix deserialization of negative transaction exit codes #115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix deserialization of negative transaction exit codes.
At the moment
CellSlice#loadUint
method is used forexitCode
deserialization inComputePhaseVMDetails
class. But exit codes can be negative (for examples, -14), soCellSlice#loadInt
should be used instead as I understand.Steps to reproduce the problem:
ComputePhaseVMDetails#getExitCode
method.Expected result: exit code equals -14.
Actual result: exit code equals 4294967282.
Unit test example: