Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TFP-5818): avslutt kobling og fjern inaktive grunnlag task. #2636

Merged
merged 11 commits into from
Mar 3, 2025

Conversation

mrsladek
Copy link
Collaborator

@mrsladek mrsladek commented Feb 28, 2025

No description provided.

Copy link
Collaborator

@jolarsen jolarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrsladek LGTM - men er det ikke like greit å kjøre delete på direkten uten task?
Kallene vil komme i systemkontekst så det skal ikke være tilgangsproblem.
Ved massekjøring så kan det være mer effektiv throttling enn å opprette tasks

Ref forvaltning / oppdateraktørid for splitt/merge.

Copy link
Collaborator

@jolarsen jolarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut. Men tenker det er like greit å slette på direkten.
Da blir rett nok feilen synlig i fpsak - men tenker det er like greit framfor delayed feil.

@mrsladek
Copy link
Collaborator Author

mrsladek commented Mar 3, 2025

Ja jeg tenkte i starten at den skal slette resten av grunnlaget også... men syns en asynk rydding senere kan være bedre.

@mrsladek mrsladek merged commit 55458e7 into master Mar 3, 2025
12 checks passed
@mrsladek mrsladek deleted the feat/TFP-5818_avslutt_task branch March 3, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants