Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Use yarn frozen lockfile #14050

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

rosskevin
Copy link
Member

@rosskevin rosskevin commented Dec 31, 2018

Found the ci config to be a bit out of date on the yarn cache and problematic yarn command which can cause unexpected diffs:

  • use --frozen-lockfile to avoid diff between repo and ci runs
  • update the yarn cache to that reported by the cli in the Check versions and env step

extracted from #14048 (in case that one needs closed)

@oliviertassinari
Copy link
Member

@rosskevin How do you want to move forward?

paths:
- ~/.cache/yarn/v1
- ~/.cache/yarn/v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2

@rosskevin
Copy link
Member Author

rosskevin commented Jan 2, 2019

Given the false errors on the ci diff step we have options:

  1. accept this PR as-is because it solves that (preferably with dependency update automation)
  2. kill the ci diff step and remove frozen from this PR
  3. kill the frozen from this PR and ?? whenever there is a diff problem in the future try to figure it out?

@oliviertassinari oliviertassinari changed the title update yarn cache location based on cli output [test] Use yarn frozen lockfile Jan 2, 2019
@oliviertassinari
Copy link
Member

  1. sounds good. I have reverted the cache version. It that OK for you?

@rosskevin
Copy link
Member Author

Why revert the cache version when the CLI is reporting the location as v4?

@eps1lon do we still need the offline workaround? If not we don't need the cache version at all, just take out the offline code and strip off the yarn cache version segment altogether as recommended by https://circleci.com/docs/2.0/yarn/

@rosskevin
Copy link
Member Author

rosskevin commented Jan 2, 2019

One point of this PR @oliviertassinari was to update the cache and use the directory reported by yarn on ci, I'm not sure why you have removed that change. To me it appears you put it back to using a no-longer used/stale cache dir.

@rosskevin
Copy link
Member Author

continuous_integration_and_deployment

@oliviertassinari
Copy link
Member

Oh ok. I'm reverting my change.

@rosskevin
Copy link
Member Author

This is good to merge as-is. If we are at the point where we can dump the offline cache we can simplify it further so we don't spec a version at all.

@oliviertassinari oliviertassinari merged commit 9b9f5da into mui:master Jan 3, 2019
@rosskevin rosskevin deleted the update-yarn-cache branch January 25, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants