-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Use yarn frozen lockfile #14050
Conversation
@rosskevin How do you want to move forward? |
paths: | ||
- ~/.cache/yarn/v1 | ||
- ~/.cache/yarn/v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v2
Given the false errors on the ci
|
|
Why revert the cache version when the CLI is reporting the location as @eps1lon do we still need the offline workaround? If not we don't need the cache version at all, just take out the offline code and strip off the yarn cache version segment altogether as recommended by https://circleci.com/docs/2.0/yarn/ |
One point of this PR @oliviertassinari was to update the cache and use the directory reported by yarn on ci, I'm not sure why you have removed that change. To me it appears you put it back to using a no-longer used/stale cache dir. |
Oh ok. I'm reverting my change. |
e78604b
to
5e0e62b
Compare
This is good to merge as-is. If we are at the point where we can dump the offline cache we can simplify it further so we don't spec a version at all. |
Found the ci config to be a bit out of date on the yarn cache and problematic
yarn
command which can cause unexpected diffs:Check versions and env
stepextracted from #14048 (in case that one needs closed)