[Tabs][RadioGroup] Handle modifier keys #1529
Open
+194
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
component: tabs
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mj12albert
force-pushed
the
fix/tab-modifier-keys
branch
from
bee18f6 to
84117fc
Compare
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
mj12albert
force-pushed
the
fix/tab-modifier-keys
branch
from
e11041c to
f1a7674
Compare
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
fix/tab-modifier-keys
branch
from
f1a7674 to
8fb06fe
Compare
github-actions
bot
removed
the
PR: out-of-date
mj12albert
force-pushed
the
fix/tab-modifier-keys
branch
from
8fb06fe to
bcf14fe
Compare
atomiks
reviewed
Mar 6, 2025
| @@ -76,6 +94,7 @@ export function useCompositeRoot(params: UseCompositeRootParameters) { | |||
| enableHomeAndEndKeys = false, | |||
| stopEventPropagation = false, | |||
| disabledIndices, | |||
| modifierKeys = [], | |||
There was a problem hiding this comment.
Should this default be specified outside so it's a stable reference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1465
All composite components will now prevent arrow key navigation if any modifier key (Shift, Ctrl, Alt, Meta) is pressed by default unless it's allowed with the
modifierKeysprop.The exception is RadioGroup since HTML radio groups work normally when
Shiftis held (example)Demo:
Tabs will no longer navigate if any modifier key is pressed: https://deploy-preview-1529--base-ui.netlify.app/react/components/tabs
RadioGroup works normally if
Shiftis pressed: https://deploy-preview-1529--base-ui.netlify.app/react/components/radioI have followed (at least) the PR section of the contributing guide.