[NumberField] Prevent virtual cursor overlapping native one #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomiks
added
the
component: number field
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: atomiks <[email protected]>
github-actions
bot
added
the
PR: out-of-date
|
Can you share a screen-recording of this? I can't reproduce it, it was make it clear what's the PR about. |
|
@mnajdova it's hard to see in the screen recording (I tried) because the flicker of the two overlapping cursors is so quick. Essentially, you briefly saw two simultaneous cursors (native and our fake HTML one - can repro old on live As long as you see it looks good now, that's fine |
Signed-off-by: atomiks <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
Signed-off-by: atomiks <[email protected]>
Signed-off-by: atomiks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The virtual cursor currently can overlap the native one since the state can be set before the pointer lock promise (previously had wrong types in TS itself - it's now correct) finishes. Removed the flicker timeout as a result