[query_data example] max_chunk_overlap in PromptHelper must be in 0..1 range #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quoing
force-pushed
the
fix_query_data_example
branch
from
72e8471 to
cbcc907
Compare
|
long time I didn't tried the llama index example, is that something that changed recently? Shall we pin the llama index version maybe to the requirements.txt? |
|
@mudler Unfortunately I don't know.. I just get to this project and wanted to try it.. query_data example was first thing I tried and ran into issues (I found issue #132 (comment) , which referenced the same).. store.py crashed with error: ValueError: chunk_overlap_ratio must be a float between 0. and 1. |
|
I see, thanks @quoing ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple fix, percentage value is expected to be float in range 0..1
Notes for Reviewers
Signed commits