Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libdvd{read,nav}: add patches to fix clang64 #23613

Merged
merged 3 commits into from
Mar 10, 2025
Merged

Conversation

kasper93
Copy link
Contributor

@kasper93 kasper93 commented Mar 8, 2025

Patches needed to make it work in clang64 env. Tested with mpv and ffmpeg demuxers.

Fixes: #23211

kasper93 added 3 commits March 8, 2025 15:45
Fixes clang64 binaries. See individual patches for more details.

Fixes: msys2#23211
Fixes clang64 binaries. See individual patches for more details.

Fixes: msys2#23211
@kasper93
Copy link
Contributor Author

kasper93 commented Mar 8, 2025

cc @robUx4 if you want to look at it. Do you know if there are plans to release libdvd{read,nav} in some not too distance future? Since some patches are not yet merged, I figured to pull the patches here before we get proper release.

@kasper93
Copy link
Contributor Author

kasper93 commented Mar 8, 2025

[MSYS2 CI] FAILURE: mingw-w64-gst-plugins-bad: failed.
PermissionError: [Errno 13] Permission denied: 'C:/Users/runneradmin/.cache/g-ir-scanner/073ec3659162d2f3ea2844eacf38e55bb8a7c97d'

This does not look related to my changes.

@ognevny
Copy link
Collaborator

ognevny commented Mar 9, 2025

[MSYS2 CI] FAILURE: mingw-w64-gst-plugins-bad: failed.
PermissionError: [Errno 13] Permission denied: 'C:/Users/runneradmin/.cache/g-ir-scanner/073ec3659162d2f3ea2844eacf38e55bb8a7c97d'

This does not look related to my changes.

restarted

@robUx4
Copy link
Contributor

robUx4 commented Mar 9, 2025

cc @robUx4 if you want to look at it. Do you know if there are plans to release libdvd{read,nav} in some not too distance future? Since some patches are not yet merged, I figured to pull the patches here before we get proper release.

No idea, I have no control over that. cc @jbkempf

@lazka lazka merged commit 62e756f into msys2:master Mar 10, 2025
12 of 13 checks passed
@leaperstuff
Copy link

Can you explain in a bit of more detail?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mpv] missing cdda & dvdnav features
5 participants