Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import ABC from collections.abc instead of collections for Python 3 compatibility #42

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Import ABC from collections.abc instead of collections for Python 3 compatibility #42

merged 1 commit into from
Sep 10, 2021

Conversation

tirkarthi
Copy link

Fixes #41

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c6aae38 on tirkarthi:fix-collections into 5b2a27f on mriehl:master.

@nmichaels-cc
Copy link

This has been here for well over a year. Is this project in need of a new maintainer?

@mriehl
Copy link
Owner

mriehl commented Sep 10, 2021

This has been here for well over a year. Is this project in need of a new maintainer?

Yeah sort of. Sorry for dropping the ball on this, I haven't been using python for anything serious in the last years so I'm a bit out of the loop.
I am merging this and I'll look into making a pypi release this week end.

@mriehl mriehl merged commit 1ed6950 into mriehl:master Sep 10, 2021
@mriehl
Copy link
Owner

mriehl commented Sep 10, 2021

I released 2.1.6 to PyPI with this fix. Sorry for the >1year wait.

@tirkarthi
Copy link
Author

Thanks @mriehl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing ABC directly from collections was removed in Python 3.9
4 participants