-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGPURenderer: Add setOutputRenderTarget()
#30459
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Should we call it |
If the parameter is always a render target, I would adhere to the To clarify the name |
setOutputTarget()
setOutputRenderTarget()
There is one remaining issue: After this PR when leaving a XR session, There are no warnings/errors in the browser console so I suspect the engine does not properly detect the render target state change. |
Related issue: #30387 (comment)
Description
The PR introduced
Renderer.setOutputRenderTarget()
which is focused on screen output, making it less confusing to use RenderTargets and initial support forPostProcessing
inXRManager
.