update plot method #87
Conversation
- plot method no longer shows grob table - documentation updated - version bumped to devel - news updated This will fix #86 when merged
|
Note: this is failing on the macos flavor because it can't seem to install MCMCpack 🤔 |
There was a problem hiding this comment.
Thanks @zkamvar - this looks good to me, although one typo hasn't been fixed correctly.
I have also added comments that I would just bump the version to 2.2-2, but I work in Python these days so if you think what you have is a better convention then I'll defer to you on that one.
Tests are failing on the old release of R because this uses R 3.5 and MCMC pack requires R>=3.6. Since we depend on MCMC, that means we also require R>=3.6. I would simply remove the oldrel job from the tests by removing the two lines here: https://github.com/annecori/EpiEstim/blob/master/.travis.yml#L12. We will also need to update our CRAN page etc to say the supported R version is >=3.6. Given the MCMC dependency, I guess it already won't install on older R versions anyway...
Co-Authored-By: Jake Stockwin <[email protected]>
Co-Authored-By: Jake Stockwin <[email protected]>
Co-Authored-By: Jake Stockwin <[email protected]>
This is to account for the fact that MCMCpack now relies on R 3.6
|
Hm also @zkamvar would it actually be worth changing https://github.com/annecori/EpiEstim/blob/master/DESCRIPTION#L24 to show the R >=3.6 dependency we now have? |
I'm of two minds on this: on the one hand, it will still work with older versions of {MCMCpack}, which did not have a dependency on R >=3.6. At the moment, people only have to update their R version if they update {MCMCpack}, but not if they update {EpiEstim} (CI is a bit of a different story). If we force {EpiEstim} to require R >= 3.6, then we force the users to upgrade their version of R (not terribly drastic, but frustrating for some users). |
|
@zkamvar makes sense, happy for you to merge in that case |
This will fix #86 when merged