feat(public API): expose hashing to curve for BN254 and BLS12-381 #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For @Mikerah for differential testing/fuzzing vs https://github.com/hashcloak/bn254-hash-to-curve
AFAIK all crypto libraries use the same internal representation:
a' = aR (mod p)
and R = 2²⁵⁶ (mod p) for BN254 (i.e. the next multiple of the word size)Hence you should be able to cast Constantine <-> Arkworks similar to what I do for Halo2curves here with
mem::transmute::<MaybeUninit<bn254_snarks_g1_aff>, ark_bn254::G1Affine>
constantine/constantine-rust/constantine-halo2-zal/src/lib.rs
Lines 43 to 55 in 9268502