video/vdpau: change is_preempted bool to atomic

[kasper93]

And eliminate recursive lock. This doesn't have to be guarded by mutex, if for some reason preemption happens while we are handling preemption, we remember the flag and do the dance gain. This is even nicer than locking preemption callback.

[github-actions]

Download the artifacts for this pull request:

Windows

• mpv-i686-w64-mingw32
• mpv-x86_64-w64-mingw32
• mpv-x86_64-windows-msvc

macOS

• mpv-macos-13-intel
• mpv-macos-14-arm
• mpv-macos-15-arm

[Dudemanguy]

Pinging @DanOscarsson. Sorry to bug but could you check if this PR works for you?

[DanOscarsson]

As I normally never gets preemption it is not that easy to test. Also have just upgraded my os so will take some time before I can compile and test.
Looking at the diff I think it looks ok.
The only thing I can see is that win_x11_init_vdpau_procs will probably give a message it did not before, if creating device fails. This because is_preempted is now reset in beginning of handle_preemption.
As I have not had a preemption that I remember I cannot say if
this would be annoying. It should not change the handling, from what I can see in the code.
That is what I see by just looking at the code and the diff.

[kasper93]

The only thing I can see is that win_x11_init_vdpau_procs will probably give a message it did not before, if creating device fails.

Yes, it would trigger different log message. I've seen that, but wasn't too concerned about it. It wasn't even synchronized before, but since win_x11_init_vdpau_procs suppose to be called only in two places, I can make it not check the flag at all.

EDIT:

Fixed log message.