Trim whitespace in gcov version number candidates #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marco-c any chance you could take a look at this? |
|
Sorry for the delay @feo-elektronik-may. Could you add a test for this (within test_parse_version)? |
You mean something other than just the What exactly do you have in mind? |
|
Oh, really sorry, I don't know how I missed that added line! |
marco-c
reviewed
Sep 25, 2024
marco-c
previously approved these changes
Sep 25, 2024
feo-elektronik-may
force-pushed
the
fix_carriagereturn_versions
branch
from
0efbc63 to
a27844b
Compare
This fixes version number parsing for platforms where \r\n is used to terminate lines.
feo-elektronik-may
force-pushed
the
fix_carriagereturn_versions
branch
from
a27844b to
2821658
Compare
marco-c
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes version number parsing for platforms where
\r\nis used to terminate lines.Fixes #919.