Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert MethodViews to module functions for API requests #3092

Merged
merged 53 commits into from
Mar 7, 2024
Merged

Convert MethodViews to module functions for API requests #3092

merged 53 commits into from
Mar 7, 2024

Conversation

michellemounde
Copy link
Contributor

Refactor MethodViews classes to functions to attend API requests. Fixes #1102

@michellemounde
Convert permissions other than scheduled changes to functions
2c0f2a8
@michellemounde
Remove permissions view from module export list
92dec20
@michellemounde
Lint fixes
4e6e1ce
@michellemounde
Add transaction and exception handlers to permission functions
349cb1a
@michellemounde
Update functions with required parameters
ebe5c88
@michellemounde
Import sorting
c51fa2d
@michellemounde
Modify debugging of request path into a decorator function
2e12c19
@michellemounde
Refactor required signoffs other than scheduled changes and history
d720837
@michellemounde
Change rules views to functions minus scheduled chnages and history v…
5378f3e 
…iews
@michellemounde
Modify SingleRelaseView and SingleLocaleView class methods to functions
17da61d
@michellemounde
Change ReleaseReadOnly AdminViews to functions
7300776
@michellemounde
Refactor ReleasesAPIView and SingleReleaseColumnView to functions
814bf14
@michellemounde
Modify ScheduleReleaseDiffView and ScheduleReleaseFieldView to functions
0cdb22a
@michellemounde
Lint fixes
0a7f3e8
@michellemounde
Redefine symbols to be exported from permissions module with refactor…
da7939a 
…ed functions
@michellemounde
Fix put_rules_id_or_alias to handle general exceptions with correct r…
6fbef36 
…equest method
@michellemounde
Combine Flask imports to one line in base view
a0a59ea
@michellemounde
Revert a0a59ea
4538c2c
@michellemounde
Modify ScheduledChangesView and PermissionScheduledChangesView to fun…
b9d4f91 
…ctions
@michellemounde
Convert RequiredSignoffsScheduledChangesView to functions
885e887
@michellemounde
Convert RulesScheduledChangesView to functions
68042e7
@michellemounde
Convert ReleaseScheduledChangesView to functions
9deec60
@michellemounde
Convert PinnableReleaseScheduledChangesView to functions
61ab5ba
@michellemounde
Rename scheduled changes permissions in plural
594015e
@michellemounde
Refactor ScheduledChangesView in emergency shutoff to functions
0bd7578
@michellemounde
Lint fixes
ec55dae
@michellemounde
Add missing request body params to scheduled changes functions
4f7203f
@michellemounde
Modify ScheduledChangeView and PermissionScheduledChangeView to funct…
eec09f8 
…ions
@michellemounde
Change RequiredSignoffScheduledChangeView to functions
96114f1
@michellemounde
Change RuleScheduledChangeView to functions
dab0e96
@michellemounde michellemounde force-pushed the method-views-to-modules branch from 90901c0 to 40f4aaa Compare February 9, 2024 16:00
@gabrielBusta gabrielBusta self-assigned this Feb 13, 2024
@michellemounde
Convert SignoffsView and its subclasses to functions
2822797
@michellemounde
Change HistoryView and HistoryAPIViews to functions
336441f
@michellemounde
Modify ScheduledChangeHistoryView to functions
233ae7b
@michellemounde
Convert ScheduledChangeHistoryView child classes to functions
c2c7b86
@michellemounde
Lint fixes
290b029
@michellemounde
Modify required signoffs get_filters helper function to only pass nee…
b792c87 
…ded variables
@michellemounde
Accept object change id in rules history functions
384c10e
@michellemounde
Clean up print statements and TODO's
b6e4290
@michellemounde
Delete base AdminView
bd038ca
@michellemounde
Lint fixes
f7fbeb3
@michellemounde
Remove debugPath decorator and modify handleGeneralExceptions to read…
d73ee4e 
… method from request
@michellemounde
Modify requirelogin to use connexion.request
ff994e6
@michellemounde
Remove docstrings with request paths
92a2e5c
@michellemounde
Sort imports
dbf4578
@michellemounde
Add handleGeneralExceptions to post functions that were missing it
49d8f1d
@michellemounde
Remove kwargs in delete emergency_shutoff
166b812
@michellemounde
Use data version directly in delete_scheduled_change
e846d5c
@michellemounde michellemounde marked this pull request as ready for review February 20, 2024 14:29
@gabrielBusta gabrielBusta merged commit a59bf45 into mozilla-releng:main Mar 7, 2024
10 checks passed
@jbuck jbuck mentioned this pull request Jun 15, 2024
Merged
jbuck pushed a commit to jbuck/balrog that referenced this pull request Jun 15, 2024
@michellemounde @jbuck
Convert MethodViews to module functions for API requests (mozilla-rel…
7b88841 
…eng#3092)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielBusta gabrielBusta gabrielBusta approved these changes

@jcristau jcristau Awaiting requested review from jcristau jcristau is a code owner

@gbrownmozilla gbrownmozilla Awaiting requested review from gbrownmozilla

Assignees

@gabrielBusta gabrielBusta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stop using MethodViews in flask apps
2 participants
@michellemounde @gabrielBusta