Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geojson and topojson for South Sudan (SSD) #406

Merged
merged 6 commits into from
Oct 19, 2020
Merged

Add geojson and topojson for South Sudan (SSD) #406

merged 6 commits into from
Oct 19, 2020

Conversation

jamespwilliams
Copy link
Contributor

Currently, this repo doesn't contain geojson or topojson for South Sudan (ISOA3 SSD), and the files for Sudan include South Sudan's region.

This MR brings the files for South Sudan and Sudan in line with the current Natural Earth dataset - i.e: South Sudan has its own region, and Sudan's region now doesn't include South Sudan.

The files from this MR have been converted from Natural Earth's data (in particular, https://www.naturalearthdata.com/downloads/10m-cultural-vectors/) using QGIS.

Fixes #349

@jamespwilliams
Copy link
Contributor Author

Just noticed the other geojson files in this repo use a different format to the ones introduced in this MR (FeatureCollection vs GeometryCollection). Will fix now

@mledoze
Copy link
Owner

mledoze commented Oct 19, 2020

Hello @jamespwilliams thank you for your contribution.

Could you please add an entry in the changelog?

@jamespwilliams
Copy link
Contributor Author

Hi, sure, I've just added an entry to the changelog

@mledoze mledoze merged commit 0d77255 into mledoze:master Oct 19, 2020
@mledoze
Copy link
Owner

mledoze commented Oct 19, 2020

It's merged, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

South Sudan is empty, but Sudan has it included
2 participants