Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mj-social-element when inline style is added #1160

Closed
wants to merge 1 commit into from

Conversation

Br1mbelle
Copy link

When inline style is added, the first social element is centered but the following are on the left side.

The TD tag of mj-social-element is not well closed and juice add closing tags and change the html code.

Tested with the following MJML :

<mjml>
  <mj-head>
    <mj-style inline="inline"></mj-style>
  </mj-head>
  <mj-body>
    <mj-section>
      <mj-column>
        <mj-social mode="horizontal">
          <mj-social-element name="facebook" href="https://mjml.io/">
            Facebook
          </mj-social-element>
          <mj-social-element name="google" href="https://mjml.io/">
            Google
          </mj-social-element>
          <mj-social-element  name="instagram" href="https://mjml.io/">
            Instagram
          </mj-social-element>
        </mj-social>
      </mj-column>
    </mj-section>
  </mj-body>
</mjml>

@kmcb777
Copy link
Collaborator

kmcb777 commented Apr 25, 2018

@Br1mbelle Hi, thanks for finding this 👍
The fix is ok for me

@kmcb777
Copy link
Collaborator

kmcb777 commented Apr 25, 2018

We first merge into next, not directly into master, so i'll close this one

@kmcb777 kmcb777 closed this Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants