Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mj-accordion and mj-carousel use cell-spacing and cell-padding instead of cellspacing and cellpadding #2636

Closed
caseyjhol opened this issue Feb 21, 2023 · 1 comment · Fixed by #2638
Closed

mj-accordion and mj-carousel use cell-spacing and cell-padding instead of cellspacing and cellpadding #2636

caseyjhol opened this issue Feb 21, 2023 · 1 comment · Fixed by #2638

Comments

@caseyjhol
Copy link
Contributor

caseyjhol commented Feb 21, 2023 •
edited
Loading

Describe the bug
The mj-accordion and mj-carousel components use cell-spacing and cell-padding attributes instead of cellspacing and cellpadding. This is invalid HTML (not supported in Chrome and likely other browsers) and does not align with the attributes other components use.

image
@caseyjhol caseyjhol mentioned this issue Feb 21, 2023
Closed
@iRyusa
Copy link
Member

iRyusa commented Feb 21, 2023

Totally a typo here, even if it's just here as a reset, let's fix that

caseyjhol added a commit to caseyjhol/mjml that referenced this issue Feb 21, 2023
@caseyjhol
[FIX] mjmlio#2636 fix cellspacing/cellpadding attributes for accordio…
667e942 
…n and carousel
@caseyjhol caseyjhol mentioned this issue Feb 21, 2023
Merged
iRyusa pushed a commit that referenced this issue Feb 24, 2023
@caseyjhol @iRyusa
[FIX] #2636 fix cellspacing/cellpadding attributes for accordion and …
7c8ee3f 
…carousel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] #2636 fix cellspacing/cellpadding attributes for accordion and carousel caseyjhol/mjml
2 participants
@iRyusa @caseyjhol