You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
you might get errors with not being able to find the includes as comments in the html, but they should be validation errors IMO as they represent a serious ommission with the rendered html.
To Reproduce
Have mj-includes in a subdirectory.
Expected behavior mostlyRenderedHTML.errors should not be [], or strict validation should throw an error.
MJML environment (please complete the following information):
OS: Linux
MJML Version 4.2
MJML tool used node package
The text was updated successfully, but these errors were encountered:
Yes it would be quite logical indeed.
The only problem is that mj-includes are completely handled by the parser, and the parser only returns the JSON mjml, we'll have to modify the structure of the parser's output to be able to handle this.
This would break projects that use the parser directly, like passport :/
Mhhh right, but when parsing it, we replace non valid include by an mj-raw comment. Can we just maybe add an extra "hidden" params to this node and just read it on mjml-validator ?
Describe the bug
If you use mj-include, when you call eg.
you might get errors with not being able to find the includes as comments in the html, but they should be validation errors IMO as they represent a serious ommission with the rendered html.
To Reproduce
Have mj-includes in a subdirectory.
Expected behavior
mostlyRenderedHTML.errors
should not be[]
, or strict validation should throw an error.MJML environment (please complete the following information):
The text was updated successfully, but these errors were encountered: