mjml-core miss babel-runtime dep

[natesilva]

The mjml-core module doesn’t work as a standalone module. It errors on import.

Use case: The main mjml module brings in a ton of dependencies that we don’t want (including mjml-cli which brings in the somewhat problematic fsevents via chokidar). We just need the mjml2html() function so I hoped to get that from mjml-core.

Reproduction Steps:

$ npm i mjml-core
   [ …usual install output… ]
$ node
> var mjmlCore = require('mjml-core');
Error: Cannot find module 'babel-runtime/helpers/toConsumableArray'
    at Function.Module._resolveFilename (module.js:538:15)
    at Function.Module._load (module.js:468:25)
    at Module.require (module.js:587:17)
    at require (internal/module.js:11:18)

MJML version:

4.0.0
Node: 8.9.4
NPM: 5.6.0

[iRyusa]

Hi @natesilva

Thanks for reporting this, looks like babel-runtime is missing on a lot of packages ! Nice catch 👍

You can "bypass" temporarily it by adding the babel-runtime to your project

[matass]

hi @iRyusa

I have added babel-runtime (6.26.0), now I'm getting this error:

events.js:160
      throw er; // Unhandled 'error' event
      ^
Error: Error in file /xxx/xxx.mjml: Cannot read property 'mj-container' of undefined

[iRyusa]

Really weird error considering that mj-container doesn't exist anymore, can you try to reinstall or provide the template to reproduce?

[matass]

I'm using mjml-core in my own package (https://github.com/matass/swu-mjml). so I'll try to make fresh mjml app and compile some templates

[iRyusa]

Looks like a dep issue in your project, you're using mjml-core 4.0 + gulp-mjml (MJML3.0 dep).

Note that gulp-mjml isn't up to date with MJML4

[matass]

Ok, thanks. I think I have to rollback to previous mjml-core version. Do You have any plans to make mjml-4 compatible with gulp-mjml?

[iRyusa]

Here mjmlio/gulp-mjml#34 but we're focusing on MJML4 fixes before.

[kmcb777]

Hi @natesilva this has been fixed in the new release mjml4.2-beta, which you can install with npm install mjml, you can check if it solves the problem

[natesilva]

Thank you. It works.