Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading nyc to bump up handlebars #771

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrading nyc to bump up handlebars #771

wants to merge 2 commits into from

Conversation

annagav
Copy link
Contributor

@annagav annagav commented Aug 19, 2019

What are the relevant tickets?

Fix security alert for handlebars

What's this PR do?

Upgrade nyc

How should this be manually tested?

nothing should break

@codecov-io
Copy link

Codecov Report

Merging #771 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
+ Coverage   95.26%   95.32%   +0.06%     
==========================================
  Files         182      182              
  Lines        7132     7229      +97     
  Branches      245      245              
==========================================
+ Hits         6794     6891      +97     
  Misses        305      305              
  Partials       33       33
Impacted Files Coverage Δ
static/js/components/VideoList.js 100% <0%> (ø) ⬆️
static/js/components/material/Checkbox.js 100% <0%> (ø) ⬆️
...atic/js/components/analytics/AnalyticsInfoTable.js 100% <0%> (ø) ⬆️
static/js/reducers/commonUi.js 100% <0%> (ø) ⬆️
static/js/reducers/collectionsPagination.js 100% <0%> (ø) ⬆️
static/js/components/ErrorMessage.js 100% <0%> (ø) ⬆️
static/js/containers/WithDrawer.js 100% <0%> (ø) ⬆️
static/js/components/dialogs/DeleteVideoDialog.js 100% <0%> (ø) ⬆️
static/js/components/material/Textfield.js 100% <0%> (ø) ⬆️
static/js/reducers/collectionUi.js 100% <0%> (ø) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f348d37...7d6909c. Read the comment docs.

Copy link

@tasawernawaz tasawernawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine 👍
It looks like new version of eslint throwing lot of errors. You have to fix them.

@pdpinch
Copy link
Member

pdpinch commented Sep 13, 2019

@annagav Should we close this, or keep it open and try again later?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants