Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for S3Select API #108

Merged
merged 1 commit into from
Mar 8, 2019
Merged

Add support for S3Select API #108

merged 1 commit into from
Mar 8, 2019

Conversation

donatello
Copy link
Member

No description provided.

@donatello donatello force-pushed the sql-fix branch 4 times, most recently from a29d7cb to 0636640 Compare February 28, 2019 00:37
@donatello donatello requested a review from krisis February 28, 2019 01:00
harshavardhana
harshavardhana approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested

@donatello donatello requested a review from harshavardhana March 1, 2019 19:56
harshavardhana
harshavardhana previously approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested

@donatello donatello force-pushed the sql-fix branch 2 times, most recently from 2f269bf to bb4bd10 Compare March 8, 2019 22:03
@donatello
Copy link
Member Author

Added more tests and documentation. I think its ready to take in.

harshavardhana
harshavardhana approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & tested

@harshavardhana harshavardhana merged commit 72bf081 into minio:master Mar 8, 2019
@donatello donatello deleted the sql-fix branch March 9, 2019 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisis krisis krisis approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donatello @krisis @harshavardhana