[machine]:windows node setup #13
Open
+372
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iankingori
reviewed
Jan 8, 2025
iankingori
reviewed
Mar 3, 2025
iankingori
reviewed
Mar 3, 2025
iankingori
reviewed
Mar 5, 2025
| @@ -560,3 +558,50 @@ func (d *Driver) generateDiskImage() (string, error) { | |||
|
|
|||
| return diskImage, nil | |||
| } | |||
|
|
|||
| func writeSSHKeyToVHDX(vhdxPath, publicSSHKeyPath string) error { | |||
| mountDir := "E:\\" | |||
There was a problem hiding this comment.
This will fail if I have an existing drive E on my computer. Can we retrieve the assigned drive letter after mount?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the Hyper-V driver to support Windows Server VHD images. The most important changes include adding new fields to the
Driverstruct, updating the driver creation and pre-create check methods, and implementing a new method for handling SSH keys in VHDX files.Support for Windows Server VHD:
drivers/hyperv/hyperv.go: Added new fieldsWindowsVHDUrlandOSto theDriverstruct, and set default values for Windows Server VHD URL and image filename. Updated theNewDriverfunction to initializeWindowsVHDUrlwith the default value. [1] [2] [3]Driver creation and pre-create check updates:
drivers/hyperv/hyperv.go: Modified thePreCreateCheckandCreatemethods to handle the download and setup of Windows Server VHD images. Added logic to differentiate between Linux and Windows guest OS during the creation process. [1] [2] [3] [4]New method for handling SSH keys in VHDX files:
drivers/hyperv/hyperv.go: Implemented thewriteSSHKeyToVHDXmethod to mount the VHDX file, create the necessary directories, and write the public SSH key to the appropriate location.Updates to libmachine:
libmachine/libmachine.go: AddedGuestOSfield to theHoststruct and updated theNewHostmethod to accept aguestOSparameter. Introduced theDefineGuestmethod to set the guest OS utility. [1] [2] [3] [4]Enhancements to b2d utilities:
libmachine/mcnutils/b2d.go: Added methods to handle VHD paths and check for VHD existence. IntroducedDownloadVHDandUpdateVHDCachemethods for downloading and caching Windows Server VHD images. [1] [2] [3] [4] [5]