Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix_Error_when_parent_removed : DONE #43

Merged
merged 4 commits into from
Oct 12, 2021

Conversation

ajaxspace
Copy link

@ajaxspace ajaxspace commented Oct 11, 2021

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.
Fix Red screen when popover parent is removed while popover is shown

Pre-launch Checklist

  • I read and followed the Effective Dart.
  • I listed at least one issue or feature that this PR fixes or adds in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I updated/added relevant documentation to README.md.
  • I updated/added relevant code samples to example.
  • I added new tests to check the change I am making or feature I am adding, or Minikin said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on Twitter.

Thank you for your contribution 🚀!

@minikin minikin added bug Something isn't working enhancement New feature or request labels Oct 12, 2021
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #43 (85b615a) into main (ef6a749) will decrease coverage by 0.22%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   91.18%   90.96%   -0.23%     
==========================================
  Files          11       11              
  Lines         454      454              
==========================================
- Hits          414      413       -1     
- Misses         40       41       +1     
Impacted Files Coverage Δ
lib/src/popover.dart 75.00% <ø> (-2.78%) ⬇️
lib/src/popover_item.dart 80.59% <50.00%> (-0.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef6a749...85b615a. Read the comment docs.

@minikin minikin merged commit f80cf16 into minikin:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants