EIP-1559: Add BaseFee to SignTx* #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
|
Any news on this? |
|
@ggwpez Looks good! Verified the go mod vendor changes as well. Merging. Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-etherum just released version 1.10.4 which contains updates for
EIP-1559.Among other things it added a
BaseFeeto Transactions.This MR makes go-ethereum-wallet work with the latest go-ethereum version.
It adds a
BaseFeeargument toSignTxEIP155,SignTxandSignTxWithPassphrase.I never used
go vendorbefore, so I am not sure if it worked correctly.Please have a look @miguelmota.