[UI][mac] Remove background color to show NSAddTemplate

[yamachu]

Remove button color attribute.

As shown in the image below the button is blacked out.
Remove color attribute, button is now displayed.

Before

After

[abock]

@yamachu thanks for the PR!

A few questions though:

1. Do you see this issue in one of our released builds?

2. What version of macOS are you on and what version of Xcode are you using?

[yamachu]

@abock

1. Yes, I use Xamarin Workbooks 1.4 Beta 1 (master/2e30f47)
   And I feel like I saw this issue in the previous version.
2. macOS: 10.12.6, Xcode: 9.1 (9B55)

Thanks!

[abock]

@yamachu thanks. We're all on the same macOS and Xcode as you as well.

Would you mind double checking a 1.3.2 install? For 1.4.x we moved the build to Xcode 9 which introduced a number of CALayer-related issues. I have never seen this issue before, so I'd love to verify a released build that was built against Xcode 8.3.x:

• https://dl.xamarin.com/interactive/XamarinInteractive-1.3.2.pkg

[abock]

build

[abock]

@yamachu you will actually need to fully uninstall your 1.4.0-beta1 install before installing 1.3.2:

sudo /Library/Frameworks/Xamarin.Interactive.framework/Versions/Current/uninstall

https://developer.xamarin.com/guides/cross-platform/workbooks/install/#Downgrading

[yamachu]

There is no issue in Xamarin Workbooks 1.3.2 as you mentioned.

[abock]

@yamachu excellent - that confirms it being an issue with Xcode 9.1. Thank you!

I just tested your build from VSTS and confirm that the NSVisualEffectView shines through the button still with backgroundColor removed.

[abock]

Thanks! 🎉

[sandyarmstrong]

👍 Awesome, glad we don't need this anymore. It was part of a hack to emulate NSOutlineView's sidebar style without being layer-backed.

[bojanrajkovic]

Thanks for your contribution!

[lewing]

Thanks for catching this!