Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing assertions on tests #3761

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Fix failing assertions on tests #3761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Microsoft.TestPlatform.Extensions.BlameDataCollector/BlameCollector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public override void Initialize(
/// </summary>
private void CollectDumpAndAbortTesthost()
{
TPDebug.Assert(_logger != null && _context != null && _targetFramework != null && _dataCollectionSink != null, "Initialize must be called before calling this method");
TPDebug.Assert(_logger != null && _context != null && _dataCollectionSink != null, "Initialize must be called before calling this method");
_inactivityTimerAlreadyFired = true;

string value;
Expand Down Expand Up @@ -236,7 +236,7 @@ private void CollectDumpAndAbortTesthost()
{
Action<string> logWarning = m => _logger.LogWarning(_context.SessionDataCollectionContext, m);
var dumpDirectory = GetDumpDirectory();
_processDumpUtility.StartHangBasedProcessDump(_testHostProcessId, dumpDirectory, _hangDumpType == HangDumpType.Full, _targetFramework, logWarning);
_processDumpUtility.StartHangBasedProcessDump(_testHostProcessId, dumpDirectory, _hangDumpType == HangDumpType.Full, _targetFramework!, logWarning);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In failing tests _targetFramework is null but we pass it to some mock that doesn't care. Real life scenario, the implementation of this method throws on null TFM. I could also keep the assertion and update the tests to not pass null.

This comment also applies to the other assertion below.

hangDumpSuccess = true;
}
catch (Exception ex)
Expand Down Expand Up @@ -543,13 +543,13 @@ private void TestHostLaunchedHandler(object sender, TestHostLaunchedEventArgs ar
return;
}

TPDebug.Assert(_logger != null && _context != null && _targetFramework != null, "Initialize must be called before calling this method");
TPDebug.Assert(_logger != null && _context != null, "Initialize must be called before calling this method");

try
{
var dumpDirectory = GetDumpDirectory();
Action<string> logWarning = m => _logger.LogWarning(_context.SessionDataCollectionContext, m);
_processDumpUtility.StartTriggerBasedProcessDump(args.TestHostProcessId, dumpDirectory, _crashDumpType == CrashDumpType.Full, _targetFramework, _collectDumpAlways, logWarning);
_processDumpUtility.StartTriggerBasedProcessDump(args.TestHostProcessId, dumpDirectory, _crashDumpType == CrashDumpType.Full, _targetFramework!, _collectDumpAlways, logWarning);
}
catch (TestPlatformException e)
{
Expand Down