resolve glob tasks in configure default build task #209385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
Apr 2, 2024
Tyriar
previously requested changes
Apr 2, 2024
DonJayamanne
approved these changes
Apr 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
configure default build task, we didn't resolve glob tasks, so the quick pick would present all as options, not listing the one that was the current default. This has never worked before AFAICT.The fix is to resolve the glob tasks rather than just checking if
task.isDefault(which can be astringin the case of glob tasks), is defined.fixes #191745
The issue contains good repro steps. I'm following those in the below gif to show that it works now.
demo.mov