Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: xterm dependencie #167985

Closed
wants to merge 2 commits into from
Closed

Conversation

lemanschik
Copy link

@lemanschik lemanschik commented Dec 3, 2022

it was broken because of some false pushes there where a script to correct it periodical this corrects its till it changes from beta to latest. then you can change the tag at the end the tag references always work correct.

they can get removed via modification of this commit or with a extra one you choose else they get removed by:

by the way the two above mentioned files do contain also false logic as they split into wrong frontend backend modules this leads to a desynced versioning as both use the same modules in fact.

so if you do not merge this in and delete them you need as alternativ upgrade them at last to update both sides with the same module versions remote and the repo

it was broken because of some false pushes there where a script to correct it periodical this corrects its till it changes from beta to latest. then you can change the tag at the end the tag references always work correct.
@lemanschik
Copy link
Author

lemanschik commented Dec 3, 2022

@alexdima please review
@Tyriar please review

The Ci failes because frozen broken yarn lock why is that behavior why do you freeze it can you share details?

FIx: code-oss-remote
@lemanschik
Copy link
Author

@microsoft-github-policy-service agree

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what the problem here is, the xterm updates work just fine and update in sync. I don't want the package.json to use the beta version as it must point at a specific version and it feels safer to me to point at the exact version that will be in yarn.lock.

Also you missed the remote/web folder which must also remain in sync.

by the way the two above mentioned files do contain also false logic as they split into wrong frontend backend modules this leads to a desynced versioning as both use the same modules in fact.

If you find a bug where running the script successfully does not sync all 3 package.jsons please let me know. This script is only meant for our team to run though and has works fine in the past AFAIK.

@Tyriar Tyriar closed this Dec 5, 2022
@lemanschik
Copy link
Author

@Tyriar the problem is that esm build is not working but that is ok as long as everything works for you i am fine with that i tought because of yarn correcting all the dependencies it would be clever to do it directly.

@lemanschik lemanschik deleted the fix_xterm_build branch December 5, 2022 12:48
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants