Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix both matching against wrapped lines and supporting scanning multiple lines at once #162327

Merged
merged 4 commits into from
Sep 29, 2022

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 29, 2022

Fixes #162070
Fixes #161997

@meganrogge could you please test this as well? Seems to work for me on Windows

@Tyriar Tyriar added this to the September 2022 milestone Sep 29, 2022
@Tyriar Tyriar requested a review from meganrogge September 29, 2022 11:16
@Tyriar Tyriar self-assigned this Sep 29, 2022
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working for me on mac... investigating
Screen Shot 2022-09-29 at 6 41 20 AM

EDIT:

works after merging main

Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on mac ✅

@Tyriar Tyriar merged commit 98a77dc into main Sep 29, 2022
@Tyriar Tyriar deleted the tyriar/162070_2 branch September 29, 2022 16:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants