Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using Quick Fix sound when terminal quick fix is available #161912

Closed
isidorn opened this issue Sep 27, 2022 · 1 comment · Fixed by #162226
Closed

Consider using Quick Fix sound when terminal quick fix is available #161912

isidorn opened this issue Sep 27, 2022 · 1 comment · Fixed by #162226
Assignees
@Tyriar @meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-quick-fix verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2022

Comments

@isidorn
Copy link
Contributor

isidorn commented Sep 27, 2022

Testing #161846

I believe we already have a Quick Fix available sound.
We should play this sound when the terminal has quick fix. And also when the editor has the quick fix (we planned on doing this but never implemented it I believe).
@meganrogge meganrogge added feature-request Request for new features or functionality accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues terminal-quick-fix labels Sep 27, 2022
@meganrogge meganrogge added this to the September 2022 milestone Sep 27, 2022
meganrogge added a commit that referenced this issue Sep 28, 2022
@meganrogge
fix #161912
2f6d898
@meganrogge meganrogge mentioned this issue Sep 28, 2022
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 28, 2022
@meganrogge meganrogge added the verification-needed Verification of issue is requested label Sep 29, 2022
@meganrogge
Copy link
Contributor

with editor.accessibilitySupport enabled, trigger the terminal quick fix via checking out a new branch, and git push

@rzhao271 rzhao271 added the verified Verification succeeded label Sep 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders terminal-quick-fix verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

add audio cue for terminal quick fix microsoft/vscode
5 participants
@isidorn @Tyriar @rzhao271 @meganrogge @vscodenpa