Terminal quick fix title should show the command that should be run

[isidorn]

Testing #161846

1. git checkout -b lalala
2. git push
3. Notice quick fix title is "git push lalala". Title should be what will actually be run git push --set-upstream origin lalala

Right now the user does not know what will be run, so it is surprising and does not give confidence.

[meganrogge]

Not sure if we want to show all of those details - maybe we could on hover of the action?

[isidorn]

If you do not want to render all the details then I suggest to render the first n characters and render ... at the end. That way the user can understand that we only took the beginning

And 👍 for on hover to show the whole thing

[Tyriar]

#161599 is is about coding convenience, plus this issue. For simple commands like this we should always show the full thing without hover imo (hovering also can't happen on native dropdowns). This will increase the user's trust in the feature

[isidorn]

Agreed. We could have a long command cutoff limit - 50 characters for example. After that we can render elipses ...

[Tyriar]

Commands that long are probably too complicated anyway, such as how we free the port which is a little different as it's handled outside of the terminal

[Tyriar]

I think we should also show the URL we're navigating to

vscode/src/vs/workbench/contrib/terminal/browser/terminalQuickFixBuiltinActions.ts

Line 131 in 0857860

const label = localize("terminal.gitCreatePr", "Create PR");

A good example of why this trust is important is because this:

Was navigating to https://github.com/microsoft/vscode/compare/tyriar/wording%20%20%20%20%20%20%20%20remote:To%20https:/github.com/microsoft/vscode%20*%20%5Bnew%20branch%5D%20%20%20%20%20%20%20%20%20%20%20%20%20%20tyriar/wording%20-%3E%20tyriar/wordingBranch%20'tyriar/wording'%20set%20up%20to%20track%20remote%20branch%20'tyriar/wording'%20from%20'origin'.?expand=1 due to a bug (#162074). If a user clicked "Create PR" and they go there, they may never use the feature again