Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add +/- to added/deleted lines in PR description #5224

Closed
griggi-ws opened this issue Sep 6, 2023 · 2 comments · Fixed by #5244
Closed

Add +/- to added/deleted lines in PR description #5224

griggi-ws opened this issue Sep 6, 2023 · 2 comments · Fixed by #5244
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@griggi-ws
Copy link

griggi-ws commented Sep 6, 2023

Type: Bug

  1. Start a review by adding some comments with multi-line suggestions.
  2. View the PR by double-clicking the comment in the Comments tab below.

How it looks in the changed file view:
image

How it looks in the PR view:
image

This is not useful formatting, at a glance it should be obvious what the actual suggested change is - at minimum a minus prepended would be a huge difference. With suggested changes that are just removals, the suggestion appears to be nothing more than restating what's already there.

Extension version: 0.70.0
VS Code version: Code 1.81.1 (Universal) (6c3e3dba23e8fadc360aed75ce363ba185c49794, 2023-08-09T22:20:33.924Z)
OS version: Darwin x64 22.5.0
Modes:

System Info
Item Value
CPUs Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz (8 x 2000)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) 4, 5, 5
Memory (System) 16.00GB (0.10GB free)
Process Argv --crash-reporter-id e20ab28d-80b8-49ba-88d3-d1bb6ae9ddd9
Screen Reader no
VM 0%
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vsdfh931cf:30280410
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263cf:30792227
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
vsccc:30803844
3biah626:30602489
f6dab269:30613381
a9j8j154:30646983
showlangstatbar:30737416
a2ce3375:30757347
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxpt:30805730
pythonnoceb:30805159
synctok:30821570
dsvsc013:30795093
dsvsc014:30804076
diffeditorv2:30821572

@alexr00
Copy link
Member

alexr00 commented Sep 13, 2023

It looks like you're one version behind on the extension. The latest version includes colors here:
image

Looks like the +/- should be easy to add too!

@alexr00 alexr00 self-assigned this Sep 13, 2023
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Sep 13, 2023
@alexr00 alexr00 added this to the September 2023 milestone Sep 13, 2023
@alexr00 alexr00 changed the title Suggested changes in PR view are barely parseable Add +/- to added/deleted lines in PR description Sep 13, 2023
@alexr00
Copy link
Member

alexr00 commented Sep 13, 2023

With +/-:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants