-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gdbm] Add new port, starting on version 1.24 #44186
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Noah Knegt <[email protected]>
Signed-off-by: Noah Knegt <[email protected]>
@noahknegt Have you tested all the features? I encountered an error while testing the feature: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Community feedback. Not tested.
ports/gdbm/portfile.cmake
Outdated
list(APPEND options "--enable-libgdbm-compat=yes") | ||
endif() | ||
|
||
if(NOT ${ENABLE_READLINE}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if(NOT ${ENABLE_READLINE}) | |
if("readline" IN_LIST FEATURES) | |
list(APPEND options "--with-readline") | |
else() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied feedback, with some slight modifications. Readline is automatically enabled when found on the system, and thus to avoid using it implicitly the condition is reversed. Also added a comment with a link to the original docs that explains this.
ports/gdbm/portfile.cmake
Outdated
list(APPEND options "--without-readline") | ||
endif() | ||
|
||
if(NOT ${ENABLE_MMAP}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if(NOT ${ENABLE_MMAP}) | |
if("memory-mapped-io" IN_LIST FEATURES) | |
list(APPEND options "--enable-memory-mapped-io") | |
else() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied feedback, with some slight modifications. Mmap is automatically enabled when found on the system, and thus to avoid using it implicitly the condition is reversed. Also added a comment with a link to the original docs that explains this.
This feedback includes the following: - *FTP mirrors are added* - *Readline is added as a dependency* - *Archive variable is put in quotes to prevent word splitting* Co-authored-by: @dg0yt Signed-off-by: Noah Knegt <[email protected]>
Signed-off-by: Noah Knegt <[email protected]>
I have tested all the features, but done that on my WSL running Is there any way the port can enforce a minimum version of |
Signed-off-by: Noah Knegt <[email protected]>
Thanks @dg0yt for the feedback most of it I applied and worked, made some small changes to the suggestions as for both |
"Detected when present" may need explicit control also to ensure failure when the feature is requested from the port but configuration fails to detect it.
AFAICT no such check is present in any other port. The log should be clear enough in case of error. Ubuntu 20.04 comes with autoconf 2.69. I wonder why @Mengna-Li even tests with this old version. And it is possible to use a local installation of a newer version. |
How would you do this properly, not that familiar with creating vcpkg ports yet nor with |
This PR adds a new port for the GDBM package, I need this as a required port as avahi depends on it which I would like to add after this.
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.