Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libffi] Use full CCAS path #44174

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[libffi] Use full CCAS path #44174

wants to merge 2 commits into from
+14 −8

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Mar 5, 2025 •
edited
Loading

Fixes build failures from picking system clang instead of non-system clang (Android NDK, Homebrew).
Fixes #43872.

NB:

  • For MSVC, the existing behavior of using CCAS=msvcc.sh, plus appending to PATH, is kept.
  • For non-MSVC, vcpkg_configure_make uses the full path for CC. Space characters in the full path aren't supported.
  • AFAICS CCASFLAGS are used as need. To be confirmed by CI.

@WangWeiLin-MV WangWeiLin-MV added the category:port-bug The issue is with a library, which is something the port should already support label Mar 5, 2025
@dg0yt dg0yt marked this pull request as ready for review March 5, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libffi] Build error on arm64-osx
2 participants
@dg0yt @WangWeiLin-MV