-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable wt
to inherit the working directory
#3547
Conversation
# Conflicts: # src/cascadia/WindowsTerminal/main.cpp
…l launches system32
…s the real path, but the commandline was the _alias_ path
How about adding "-d" (no argument) to let wt ignore StartingDirectory entry and start in current working directory of parent process, and "-d~" option to force wt to start in %USERPROFILE% directory? |
Honestly I'm not sure I like this change at all. Especially when you try to reconcile it with #3495. Say we had both PRs merged - how does a user open the terminal in their @qqkookie I'd take a look at #3495, since that's got a much lengthier, complete proposal for commandline arguments. |
After sitting with this a couple weekends now, I hate it. As mentioned above, it results in unexpected behavior in two cases that work well today, and solving those side-effects of this PR doesn't reconcile well with #3495. I'm going to close this PR, and use arguments proposed in that PR as the definitive answer. |
Summary of the Pull Request
Enable
wt
to inherit the working directory from the commandline and Explorer.References
PR Checklist
Detailed Description of the Pull Request / Additional comments
I don't feel totally confident in this change. This changes two scenarios, and the run dialog one I'm not super happy about:
wtd
-> Results in the Terminal being launched in the current path of explorer.wtd
-> Results in the Terminal being launched in the current path of shell.Term
(or anything to get to "Windows Terminal)" -> Results in the Terminal being launched instartingDirectory
wtd
-> Results in the Terminal being launched in %USERPROFILE%wtd
-> Results in the Terminal being launched inC:\Windows\System32
wtd
commandline here.