Touchpad scrolling not possible #979

Paul-Weisser · 2019-05-24T14:45:21Z

Environment

Windows build number: Microsoft Windows [Version 10.0.18898.1000]
Windows Terminal version (if applicable): pulled and built today (WindowsTerminalDev_0.0.1.0_x64__8wekyb3d8bbwe)

Steps to reproduce

Not entirely sure if this is intended behaviour or an issue to other users but I am not able to scroll through the new terminal with my touchpad on my Notebook (Alienware).

It works with my mouse but not with the touchpad. I can scroll through the native console/ poweshell though. Can somebody reproduce this?

Expected behavior

That I can scroll through the curren window-history using two-finger-touch on the touchpad.

Actual behavior

It wont scroll.

zadjii-msft · 2019-05-24T14:50:43Z

Can you try setting a breakpoint in TermControl::_MouseScrollHandler to see if that's getting hit?

Two-finger scrolling works just fine with my surfacebook, so I'm thinking that it's something specific to your device.

Paul-Weisser · 2019-05-24T15:32:30Z

Okay I'm starting to feel a little stupid. I cleaned the solution and build CascadiaPackage on Debug x64 with the breakpoints in TermControl::_MouseScrollHandler but it wont stop there.

I need a little help how to get VS (2019) stopping at this class...

DHowett-MSFT · 2019-05-24T16:00:56Z

You might be in need of this debugging doc.

zadjii-msft · 2019-05-24T16:03:56Z

Maybe try something that you can be sure is hitting, like TermControl::_KeyDownHandler

Paul-Weisser · 2019-05-24T23:22:51Z

Thanks @DHowett-MSFT, missed that one!

But now with a working debug-mode there are several memory-violation-exceptions popping by twinapi.appcore.dll which my VS for some reason cannot ignore... (The terminal does not crash though)
So I am not able to reach the breakpoints...

Since it seems like nobody else is having these issues I will let it be and accept the fact, that something is wrong with my maschine. But I think its still interesting, that the new terminal is the only app where I am unable to scroll with two fingers.

rehnarama · 2019-05-26T10:58:47Z

I have this issue as well though!

My touchpad uses the Synaptics ClickPad drivers, not microsoft precision drivers, perhaps there is an issue there?

rehnarama · 2019-05-26T11:01:32Z

@zadjii-msft , After some debugging:

Can you try setting a breakpoint in TermControl::_MouseScrollHandler to see if that's getting hit?

Two-finger scrolling works just fine with my surfacebook, so I'm thinking that it's something specific to your device.

The PointerWheelChanged handler bound to TermControl::_MouseScrollHandler is never called.

Maybe try something that you can be sure is hitting, like TermControl::_KeyDownHandler

All other pointer handlers (and key handlers) work as expected.

Paul-Weisser · 2019-05-26T13:07:29Z

@rehnarama
I tried both, Microsoft and synaptics drivers
Maybe it's an locale issue (I'm on a German locale)
Since there have been other issues regarding locale and getting user-input right?

rehnarama · 2019-05-27T14:50:50Z

@rehnarama
I tried both, Microsoft and synaptics drivers
Maybe it's an locale issue (I'm on a German locale)
Since there have been other issues regarding locale and getting user-input right?

Could be, (Swedish locale here at least). I've also tried a minimal UWP app, and there were no problem with firing the PointerWheelChanged event there.

I've just now noticed that, when disabling "Scroll Inactive Windows" in settings, the scrolling with an external mouse becomes unreliable as well! With unreliable I mean it works sometimes (when hovering over rendered text?), and then suddenly stops working (usually when trying to scroll empty area, but not always).

Since scrolling inactive windows doesn't work with synaptics drivers, it might be a focusing issue of some sorts? Or perhaps turning off "Scroll Inactive Windows" setting would be a seperate issue?

zadjii-msft · 2019-05-28T13:47:27Z

I really doubt that locale would affect mouse input, but I guess I'm not an expert in the input stack.

The "scroll inactive windows think" might be a good lead on tracking this bug down though. Considering I don't believe anyone on the dev team has a device this is reproing on, the more help we can get the better :)

Paul-Weisser · 2019-05-28T15:41:00Z

I can't dig into this for the next four weeks...
If nobody else fixes this until then I will have a closer look (after I fixed the weird memory access violation...)

wolf99 · 2020-03-19T07:56:25Z

Doesn't work for me either.

Terminal 0.10.761.0
Windows: 1909 (18363.720)

This hasn't worked for me since I first installed WT last year. Mouse wheel scrolling hasn't worked either (haven't tried that with the 0.10 release yet though), is there a separate issue for mouse wheel scrolling or should that be covered here also?

zadjii-msft · 2020-03-19T12:48:54Z

@wolf99 I'm sure that there's another issue that's tracking the mouse scrolling not working, but this one isn't it. I fortunately have a personal HP laptop that repros this bug with it's touchpad, so I'm going to be using that to debug and investigate. However, I'd doubt that this investigation would also apply to all mouse devices. I don't want you thinking that resolving this issue will also fix your mouse issue.

wolf99 · 2020-03-19T12:54:58Z

@zadjii-msft Just tried 0.10 release with mouse, it's working now! 😄
Glad you're able to repro the track pad issue as it is affecting a lot of people by the look of this issue.

zadjii-msft · 2020-03-24T16:06:20Z

Oh no this is horrifying.

This might not apply super broadly, but this is what I've found with my investigation this morning. I've got a HP Spectre 2017 x360 that I use at home, with a touchpad using the synaptics drivers.

From what I can tell, the Synaptics touchpads don't support "Scroll inactive windows" at all. notepad.exe, the Settings app, nothing. Even with "Scroll inactive windows when I hover over them" enabled.

I'm positive that the trackpad is the problem here, because using an external mouse works fine for both scrolling inactive windows and the Terminal on this laptop.

Turns out, this is a very broad problem. Even info from 3 years ago points at solutions that are decades old (and not verified).

What does this have to do with the Terminal?

As it turns out, XAML Islands, which we're using to host our XAML content (read: the entire UI), uses an inactive HWND to host the XAML content. So we're never even getting the mouse events in TermControl::_MouseScrollHandler. This issue is more specifically being tracked by #2606 and microsoft/microsoft-ui-xaml#2101. I'm betting that this is also going to be the root cause of this issue here.

I'm going to investigate if our root HWND gets the trackpad scrolling events that the XAML Island is ignoring. Maybe I can manually forward them to the XAML island somehow? I'm not overly optimistic at this point.

/cc @Austin-Lamb @ocalvo

pamtbaau · 2020-03-24T17:14:01Z

@zadjii-msft, I'm using a Lenovo B590 using Synaptics Touchpad v7.5 drivers.

notepad.exe scrolls fine. In fact, every app scrolls fine, except Microsoft Terminal...

Any other app you would like me to test?

Uxorious · 2020-03-24T17:22:05Z

FYI: A few releases back, it started working for me on an HP Spectre x360 with Synaptics drivers.
I can also scroll background/inactive windows.

dkter · 2020-03-24T17:33:13Z

@pamtbaau

notepad.exe scrolls fine.

does it scroll when you have another window in the foreground? (i.e. open two windows side by side, then try to scroll the inactive one.)

pamtbaau · 2020-03-24T17:52:17Z

@dkter, @zadjii-msft 🤦‍♂ You're right, it doesn't work...

Uxorious · 2020-03-24T17:55:56Z

Huh that is really interesting.
For me it works sometimes - but it depends on what the FOREGROUND app is.

For example, I tried it earlier with Outlook in the foreground and Notepad in the background.
That worked.

But when I received this last mail, I tried it again. This time with Chrome/Gmail in the foreground.
This does NOT work.

msbrunoalves · 2020-03-24T18:14:45Z

Oh no this is horrifying.

This might not apply super broadly, but this is what I've found with my investigation this morning. I've got a HP Spectre 2017 x360 that I use at home, with a touchpad using the synaptics drivers.

From what I can tell, the Synaptics touchpads don't support "Scroll inactive windows" at all. notepad.exe, the Settings app, nothing. Even with "Scroll inactive windows when I hover over them" enabled.

I'm positive that the trackpad is the problem here, because using an external mouse works fine for both scrolling inactive windows and the Terminal on this laptop.

Turns out, this is a very broad problem. Even info from 3 years ago points at solutions that are decades old (and not verified).

What does this have to do with the Terminal?

As it turns out, XAML Islands, which we're using to host our XAML content (read: the entire UI), uses an inactive HWND to host the XAML content. So we're never even getting the mouse events in TermControl::_MouseScrollHandler. This issue is more specifically being tracked by #2606 and microsoft/microsoft-ui-xaml#2101. I'm betting that this is also going to be the root cause of this issue here.

I'm going to investigate if our root HWND gets the trackpad scrolling events that the XAML Island is ignoring. Maybe I can manually forward them to the XAML island somehow? I'm not overly optimistic at this point.

/cc @Austin-Lamb @ocalvo

That probably explains why scroll doesn't work with VMWare or Virtualbox either

mquevill · 2020-03-25T13:51:14Z

Huh that is really interesting.
For me it works sometimes - but it depends on what the FOREGROUND app is.

For example, I tried it earlier with Outlook in the foreground and Notepad in the background.
That worked.

But when I received this last mail, I tried it again. This time with Chrome/Gmail in the foreground.
This does NOT work.

I have the same behavior on my system. Scrolls fine with the touchpad while inactive when Settings is in the foreground; does not scroll when Chrome is in the foreground.

When the window is active, my touchpad will not scroll at all. Mouse wheel works fine (in all cases). But I have never run into issues with any other applications with my touchpad (granted, it's an older model).

Windows Terminal 0.10.781.0
Windows 10 Pro 1909 (18363.720)
Synaptics Driver 19.2.17.55

zadjii-msft · 2020-03-25T13:55:17Z

Thanks for the clarification everyone! It seems like on my machine, I can also repro this behavior where different foreground apps change whether an inactive window can be scrolled or not. This is an incredibly peculiar bug, which might be partially related to this. I'm still trying to work on a workaround, but we'll see if that's possible or not :/

Also for good measure, let's link this to #979

Paul-Weisser · 2020-03-25T23:53:37Z

@zadjii-msft Just checked out the branch you referenced. Looks promising! Fixes this issue for me 👍

BTW: Props to your commit messages 🥇

## Summary of the Pull Request As we've learned in #979, not all touchpads are created equal. Some of them have bad drivers that makes scrolling inactive windows not work. For whatever reason, these devices think the Terminal is all one giant inactive window, so we don't get the mouse wheel events through the XAML stack. We do however get the event as a `WM_MOUSEWHEEL` on those devices (a message we don't get on devices with normally functioning trackpads). This PR attempts to take that `WM_MOUSEWHEEL` and manually dispatch it to the `TermControl`, so we can at least scroll the terminal content. Unfortunately, this solution is not very general purpose. This only works to scroll controls that manually implement our own `IMouseWheelListener` interface. As we add more controls, we'll need to continue manually implementing this interface, until the underlying XAML Islands bug is fixed. **I don't love this**. I'd rather have a better solution, but it seems that we can't synthesize a more general-purpose `PointerWheeled` event that could get routed through the XAML tree as normal. ## References * #2606 and microsoft/microsoft-ui-xaml#2101 - these bugs are also tracking a similar "inactive windows" / "scaled mouse events" issue in XAML ## PR Checklist * [x] Closes #979 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments I've also added a `til::point` conversion _to_ `winrt::Windows::Foundation::Point`, and some scaling operators for `point` ## Validation Steps Performed * It works on my HP Spectre 2017 with a synaptics trackpad - I also made sure to test that `tmux` works in panes on this laptop * It works on my slaptop, and DOESN'T follow this hack codepath on this machine.

wolf99 · 2020-04-01T20:58:52Z

Props on the effort here @zadjii-msft !
I look forward to this landing on my machine 👨‍💻

ghost · 2020-04-22T17:14:45Z

🎉This issue was addressed in #5131, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.:tada:

Handy links:

mysticatea · 2020-04-23T03:13:08Z

I have confirmed that my ThinkPad Compact USB Keyboard with TrackPoint can scroll Windows Terminal. Thank you very much!

waelkdouh · 2020-04-23T03:16:19Z

It now works on my surface book. Thanks.

wolf99 · 2020-05-02T19:26:00Z

Can confirm this is working on my HP Envy. Thanks!

ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 24, 2019

Paul-Weisser changed the title ~~Bug Report~~ Touchpad scrolling not possible May 24, 2019

ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 24, 2019

ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 24, 2019

DHowett-MSFT added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels May 24, 2019

Paul-Weisser closed this as completed May 24, 2019

ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 24, 2019

Paul-Weisser reopened this May 26, 2019

zadjii-msft added Help Wanted We encourage anyone to jump in on these. and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels May 28, 2019

DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 28, 2019

zadjii-msft mentioned this issue Mar 21, 2020

Mouse Wheel does not Scroll the content #5060

Closed

zadjii-msft added a commit that referenced this issue Mar 25, 2020

So very much code cleanup

cf9d172

Also for good measure, let's link this to #979

zadjii-msft mentioned this issue Mar 26, 2020

Manually pass mouse wheel messages to TermControls #5131

Merged

3 tasks

ghost added the In-PR This issue has a related PR label Mar 26, 2020

zadjii-msft mentioned this issue Mar 26, 2020

XAML Islands: Synaptics touchpads can't scroll XAML content microsoft/microsoft-ui-xaml#2172

Open

ghost closed this as completed in #5131 Apr 1, 2020

ghost removed the In-PR This issue has a related PR label Apr 1, 2020

ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Apr 1, 2020

miniksa mentioned this issue Apr 16, 2020

Adjusts High DPI scaling to enable differential rendering #5345

Merged

9 tasks

wolf99 mentioned this issue Jun 3, 2020

Scrolling Broken in Settings for certain devices microsoft/PowerToys#3400

Closed

zadjii-msft mentioned this issue Mar 2, 2021

Scroll wheel does not work in settings UI #9340

Closed

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Touchpad scrolling not possible #979

Touchpad scrolling not possible #979

Paul-Weisser commented May 24, 2019

zadjii-msft commented May 24, 2019

Paul-Weisser commented May 24, 2019

DHowett-MSFT commented May 24, 2019

zadjii-msft commented May 24, 2019

Paul-Weisser commented May 24, 2019 •

edited

Loading

rehnarama commented May 26, 2019

rehnarama commented May 26, 2019 •

edited

Loading

Paul-Weisser commented May 26, 2019

rehnarama commented May 27, 2019 •

edited

Loading

zadjii-msft commented May 28, 2019

Paul-Weisser commented May 28, 2019

wolf99 commented Mar 19, 2020

zadjii-msft commented Mar 19, 2020

wolf99 commented Mar 19, 2020

zadjii-msft commented Mar 24, 2020 •

edited

Loading

pamtbaau commented Mar 24, 2020

Uxorious commented Mar 24, 2020

dkter commented Mar 24, 2020

pamtbaau commented Mar 24, 2020

Uxorious commented Mar 24, 2020

msbrunoalves commented Mar 24, 2020

mquevill commented Mar 25, 2020

zadjii-msft commented Mar 25, 2020

Paul-Weisser commented Mar 25, 2020

wolf99 commented Apr 1, 2020

ghost commented Apr 22, 2020

mysticatea commented Apr 23, 2020

waelkdouh commented Apr 23, 2020

wolf99 commented May 2, 2020

Touchpad scrolling not possible #979

Touchpad scrolling not possible #979

Comments

Paul-Weisser commented May 24, 2019

Environment

Steps to reproduce

Expected behavior

Actual behavior

zadjii-msft commented May 24, 2019

Paul-Weisser commented May 24, 2019

DHowett-MSFT commented May 24, 2019

zadjii-msft commented May 24, 2019

Paul-Weisser commented May 24, 2019 • edited Loading

rehnarama commented May 26, 2019

rehnarama commented May 26, 2019 • edited Loading

Paul-Weisser commented May 26, 2019

rehnarama commented May 27, 2019 • edited Loading

zadjii-msft commented May 28, 2019

Paul-Weisser commented May 28, 2019

wolf99 commented Mar 19, 2020

zadjii-msft commented Mar 19, 2020

wolf99 commented Mar 19, 2020

zadjii-msft commented Mar 24, 2020 • edited Loading

pamtbaau commented Mar 24, 2020

Uxorious commented Mar 24, 2020

dkter commented Mar 24, 2020

pamtbaau commented Mar 24, 2020

Uxorious commented Mar 24, 2020

msbrunoalves commented Mar 24, 2020

mquevill commented Mar 25, 2020

zadjii-msft commented Mar 25, 2020

Paul-Weisser commented Mar 25, 2020

wolf99 commented Apr 1, 2020

ghost commented Apr 22, 2020

mysticatea commented Apr 23, 2020

waelkdouh commented Apr 23, 2020

wolf99 commented May 2, 2020

Paul-Weisser commented May 24, 2019 •

edited

Loading

rehnarama commented May 26, 2019 •

edited

Loading

rehnarama commented May 27, 2019 •

edited

Loading

zadjii-msft commented Mar 24, 2020 •

edited

Loading