Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Functional-Command Palette]- User is not able to move back from the New Tab sub menu as there is no functionality provided to move out of Sub menu. #7910

Closed
DasaradhaKamjula opened this issue Oct 13, 2020 · 5 comments · Fixed by #8051
Closed

[Functional-Command Palette]- User is not able to move back from the New Tab sub menu as there is no functionality provided to move out of Sub menu. #7910

DasaradhaKamjula opened this issue Oct 13, 2020 · 5 comments · Fixed by #8051
Labels
Area-CmdPal Command Palette issues and features Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Fixed Issues assigned by the accessibility team that have been fixed. HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Impact-Compliance It gotta be this way. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. WindowsTerminal_Win32
Milestone
Terminal v2.0

Comments

@DasaradhaKamjula
Copy link
Collaborator

DasaradhaKamjula commented Oct 13, 2020 •
edited
Loading

User Experience:
Users who rely on screen reader/Keyboard will not be able to navigate efficiently if there is no option provided to move out of Sub menu

Test Environment:
App: Windows Terminal Preview
Feature: Command Palette
Screen Reader: Narrator
OS: Win 10 2004 Build (19041.508)

Repro Steps:
1.Open Windows terminal Preview app
2.Open Command Palette using shortcut (Ctrl+shift+p)
3.Search for New tab command in the search field
4.Navigate to New Tab list item having sub menu and activate it .
5.Verify whether there is any option provided to move back.

Actual:
User is not able to move back from the sub menu as there is no functionality provided to move out of Sub menu.

Note: Same issue repro for Split pane and Set color scheme controls having Sub menu

Expected:
Functionality should be provided to move back from sub menu by using back button or some other way other wise user has to close command palette and open it again to get all commands
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 13, 2020
@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Impact-Compliance It gotta be this way. labels Oct 13, 2020
@zadjii-msft zadjii-msft mentioned this issue Oct 13, 2020
Open
52 tasks
@zadjii-msft zadjii-msft added Issue-Task It's a feature request, but it doesn't really need a major design. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 13, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 13, 2020
@zadjii-msft
Copy link
Member

This is a really good idea

@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Oct 15, 2020
@cinnamon-msft cinnamon-msft added the HCL-E+D Accessibility tracking label Oct 20, 2020
@zadjii-msft zadjii-msft mentioned this issue Oct 27, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Oct 27, 2020
@ghost ghost closed this as completed in #8051 Nov 5, 2020
@ghost ghost removed the In-PR This issue has a related PR label Nov 5, 2020
ghost pushed a commit that referenced this issue Nov 5, 2020
@kaihugo
Enable moving back to the root level in the command palette (#8051)
341bb4f 
This commit adds functionality so that users can move back from sub menu
whenever they want. As a result, users no longer have to close command
palette and open it again to get all commands again.

Closes #7910
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Nov 5, 2020
@DHowett DHowett added Fixed Issues assigned by the accessibility team that have been fixed. and removed Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. labels Nov 5, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Nov 5, 2020
@DHowett
Copy link
Member

DHowett commented Nov 5, 2020

@DasaradhaKamjula This has been fixed pending future release. I've reopened the bug so that you can track it.

@DHowett DHowett reopened this Nov 5, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 5, 2020
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #8051, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

@zadjii-msft zadjii-msft added the Area-CmdPal Command Palette issues and features label Dec 1, 2020
@Chandresh1007 Chandresh1007 added HCL-WindowsConsole Accessibility tracking HCL-WindowsTerminal Accessibility tracking labels Dec 7, 2020
@zadjii-msft
Copy link
Member

@Chandresh1007 If this is confirmed as fixed, can we close this issue now?

@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this issue May 20, 2021
Closed
@Priyanka-Chauhan123
Copy link
Collaborator

Issue is fixed. Verified on Windows terminal version: 1.8.1521.0 and OS version: Win 10 build 21390.2025. Hence, closing the bug.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jun 23, 2021
@Priyanka-Chauhan123 Priyanka-Chauhan123 removed the HCL-WindowsConsole Accessibility tracking label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CmdPal Command Palette issues and features Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Fixed Issues assigned by the accessibility team that have been fixed. HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Impact-Compliance It gotta be this way. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. WindowsTerminal_Win32
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Enable moving back to the root level in the command palette
6 participants
@DHowett @zadjii-msft @DasaradhaKamjula @cinnamon-msft @Chandresh1007 @Priyanka-Chauhan123