[Peek]Fix crash while loading thumbnails for small pngs #28190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaimecbernardo apologies, seems I was a bit eager in disposing of the resources and missed what other side effects those changes would cause 😕 |
Not at all. Thanks a lot for the contribution 😀 |
stefansjfw
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
After #27979 was merged some small png files started crashing peek. This seems to be caused by a early disposal of the Bitmap. Waiting before disposing made the crash go away for me.
@pedrolamas , FYI ;)
Validation Steps Performed
Before this fix, using Peek right after startup on this image crashed Peek. With this fix it doesn't crash anymore.
26118718.zip