Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(URGENT) Document type appears after "ISO" with slash unless there are copublishers #105

Closed
ronaldtse opened this issue Sep 20, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

ronaldtse commented Sep 20, 2022

Correct behavior:

  • If there are copublishers, copublishers are separated by slashes, and the document type appears after the copublishers and a space. (e.g. "ISO/IEC WD 27001")
  • If there are no copublishers, the document type is placed after a slash after "ISO". (e.g. "ISO/WD 123")

ISO WD 1000-1.3

We are not delimiting ISO from status with a slash.

This is wrong. It should have been "ISO/WD 1000-1.3".

ISO/IEC/IEEE TR 1000-1-1:2001

  • We are not delimiting publishers from document type with a slash.

This is correct. The previous ISO/IEC/IEEE/TR pattern is wrong.

Originally posted by @ronaldtse in #102 (comment)

@ronaldtse ronaldtse added the bug Something isn't working label Sep 20, 2022
@mico
Copy link
Contributor

mico commented Sep 20, 2022

@opoudjis could you help to reproduce this bug?
We already have a test for that case: https://github.com/metanorma/pubid-iso/blob/main/spec/pubid_iso/identifier_spec.rb#L767
but it didn't fail.

@opoudjis opoudjis removed their assignment Sep 22, 2022
@ronaldtse
Copy link
Contributor Author

This is fixed in #115.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants