Misc fixes #944
Merged
Misc fixes #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ashwinb
commented
Feb 3, 2025
•
ashwinb
commented
- Make sure torch + torchvision go together as deps, otherwise bad stuff happens
- Add a pre-commit for requirements.txt
ashwinb
requested review from
yanxi0830,
hardikjshah,
dltn,
raghotham,
dineshyv,
vladimirivic,
sixianyi0721 and
ehhuang
as code owners
facebook-github-bot
added
the
CLA Signed
yanxi0830
approved these changes
Feb 3, 2025
raghotham
approved these changes
Feb 3, 2025
| @@ -43,6 +43,12 @@ repos: | |||
| additional_dependencies: | |||
| - black==24.3.0 | |||
|
|
|||
| - repo: https://github.com/astral-sh/uv-pre-commit | |||
There was a problem hiding this comment.
Oh they even had a pre-commit hook?!
| @@ -0,0 +1,53 @@ | |||
| # This file was autogenerated by uv via the following command: | |||
There was a problem hiding this comment.
Is this file needed in addition to uv.lock?
There was a problem hiding this comment.
@terrytangyuan in an ideal world, this file is not needed at all. but many folks still instinctively look for this file and have processes dependent on it. that's why uv even has this export mechanism.
srikanthbachala20
pushed a commit
to srikanthbachala20/llama-stack
that referenced
this pull request
Feb 27, 2025
- Make sure torch + torchvision go together as deps, otherwise bad stuff happens - Add a pre-commit for requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.