Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interactive example heights #18518

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Fix interactive example heights #18518

merged 1 commit into from
Jul 20, 2022

Conversation

NiedziolkaMichal
Copy link
Member

Summary

This PR fixes invalid height of few interactive examples like keyword static. There are also 2 pages with interactive example commented out, but those examples don't exist: reportError & groupToMap. Can I remove them?

Motivation

Supporting details

Related issues

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@NiedziolkaMichal NiedziolkaMichal requested review from a team as code owners July 19, 2022 14:46
@NiedziolkaMichal NiedziolkaMichal requested review from Josh-Cena, schalkneethling and dipikabh and removed request for a team July 19, 2022 14:46
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:JS JavaScript docs Content:wasm WebAssembly docs labels Jul 19, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 19 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTML/Element/link
Title: <link>: The External Resource Link element
on GitHub
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/HTML/Element/a
Title: <a>: The Anchor element
on GitHub
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/getPrototypeOf
Title: Object.getPrototypeOf()
on GitHub
Flaw count: 1

  • macros:
    • wrong xref macro used (consider changing which macro you use)

External URLs

URL: /en-US/docs/Web/HTML/Element/link
Title: <link>: The External Resource Link element
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTML/Element/a
Title: <a>: The Anchor element
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_OR_assignment
Title: Bitwise OR assignment (|=)
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Operators/Left_shift_assignment
Title: Left shift assignment (<<=)
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_AND
Title: Bitwise AND (&)
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Operators/Left_shift
Title: Left shift (<<)
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_XOR
Title: Bitwise XOR (^)
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_XOR_assignment
Title: Bitwise XOR assignment (^=)
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_OR
Title: Bitwise OR (|)
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_AND_assignment
Title: Bitwise AND assignment (&=)
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Classes/static
Title: static
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Functions/rest_parameters
Title: Rest parameters
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/map
Title: TypedArray.prototype.map()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/setTime
Title: Date.prototype.setTime()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/match
Title: Symbol.match
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/getPrototypeOf
Title: Object.getPrototypeOf()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/NaN
Title: Number.NaN
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale/minimize
Title: Intl.Locale.prototype.minimize()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Segmenter/supportedLocalesOf
Title: Intl.Segmenter.supportedLocalesOf()
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat
Title: Intl.DateTimeFormat
on GitHub

No new external URLs

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/supportedValuesOf
Title: Intl.supportedValuesOf()
on GitHub

No new external URLs

URL: /en-US/docs/WebAssembly/Reference/Numeric/Truncate_float_to_float
Title: Truncate (float to float)
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 7e90bb6 into mdn:main Jul 20, 2022
@NiedziolkaMichal NiedziolkaMichal mentioned this pull request Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner automatically assigned from mdn/yari-content-javascript

@schalkneethling schalkneethling Awaiting requested review from schalkneethling schalkneethling is a code owner automatically assigned from mdn/yari-content-html

@dipikabh dipikabh Awaiting requested review from dipikabh dipikabh is a code owner automatically assigned from mdn/yari-content-mdn

Assignees
No one assigned
Labels
Content:HTML Hypertext Markup Language docs Content:JS JavaScript docs Content:wasm WebAssembly docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiedziolkaMichal @sideshowbarker