Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document teamcity usage #184

Merged
merged 4 commits into from
Nov 3, 2020
Merged

document teamcity usage #184

merged 4 commits into from
Nov 3, 2020

Conversation

nbaztec
Copy link
Collaborator

@nbaztec nbaztec commented Nov 2, 2020

Fixes #106

@nbaztec nbaztec changed the title document teamcity usge document teamcity usage Nov 2, 2020
@coveralls
Copy link

coveralls commented Nov 2, 2020

Coverage Status

Coverage remained the same at 11.679% when pulling 2257368 on docs-teamcity into 51bf80d on master.

```

`goveralls` automatically use the environment variable `COVERALLS_TOKEN` as the
default value for `-repotoken`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you mention here is valid for all CIs, however the documentation for other CIs do not mention how the environment variable is used in goveralls; I was actually thinking as part of #130 to start documenting all the CLI flags and environment variables used in the README.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we ever get to do that, this part should be removed because it would become redundant (or it should be mentioned in the documentation of the other CIs for symmetry).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, currently each CI section seems to be fair-play

Co-authored-by: gdm85 <[email protected]>
@nbaztec nbaztec merged commit 540b525 into master Nov 3, 2020
@nbaztec nbaztec deleted the docs-teamcity branch November 3, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding TeamCity service
3 participants