Add force-default-index argument to minimist parsing #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
mattdesl
added a commit
that referenced
this pull request
Jan 28, 2017
Add force-default-index argument to minimist parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem: The
forceDefaultIndexAPI option already exists but is not exposed in the CLI. This prevents me from using budo-cli unless I alwaysrm index.htmlfirst. (example: index.js yields index.html in the same directory—which is pretty handy given github web hosting).The solution: This PR adds a minimist option with hyphenated alias as well as documentation. The default behavior is otherwise unchanged. I have verified this by hand but didn't find end-to-end tests of the CLI or argument parsing to which to add a test.
Let me know if there's any details that need attention or if this is otherwise acceptable/unacceptable. Thanks so much!