-
-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix globe terrain holes at poles #5232
Fix globe terrain holes at poles #5232
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5232 +/- ##
=======================================
Coverage 91.82% 91.83%
=======================================
Files 281 281
Lines 38807 38829 +22
Branches 6765 6774 +9
=======================================
+ Hits 35634 35657 +23
Misses 3044 3044
+ Partials 129 128 -1 ☔ View full report in Codecov by Sentry. |
Does it fix the following issue as well? |
It fixes the geometry sticking out of the planet, but not the zoom controls/behaviour. |
I'll mark it as fixed as I think this is the main concern in this issue, for the problem of min zoom another issue can be opened if someone cares about it enough... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
Also fixes an artifact when globe terrain was zoomed out too much. Brings back the globe/terrain/fill-planet-pole test (see #5194), it should no longer be unstable.