Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix globe terrain holes at poles #5232

Merged
merged 8 commits into from
Dec 17, 2024

Conversation

kubapelc
Copy link
Collaborator

@kubapelc kubapelc commented Dec 17, 2024

Also fixes an artifact when globe terrain was zoomed out too much. Brings back the globe/terrain/fill-planet-pole test (see #5194), it should no longer be unstable.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (9a05cb2) to head (7d927c4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5232   +/-   ##
=======================================
  Coverage   91.82%   91.83%           
=======================================
  Files         281      281           
  Lines       38807    38829   +22     
  Branches     6765     6774    +9     
=======================================
+ Hits        35634    35657   +23     
  Misses       3044     3044           
+ Partials      129      128    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Collaborator

HarelM commented Dec 17, 2024

Does it fix the following issue as well?

@kubapelc
Copy link
Collaborator Author

Does it fix the following issue as well?

It fixes the geometry sticking out of the planet, but not the zoom controls/behaviour.

@HarelM
Copy link
Collaborator

HarelM commented Dec 17, 2024

I'll mark it as fixed as I think this is the main concern in this issue, for the problem of min zoom another issue can be opened if someone cares about it enough...

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@HarelM HarelM enabled auto-merge (squash) December 17, 2024 12:54
@kubapelc
Copy link
Collaborator Author

I've just noticed that the pole mesh is also used on mercator and it doesn't look too good, I'll try to fix that.

@HarelM HarelM disabled auto-merge December 17, 2024 12:57
@HarelM HarelM merged commit ab63cf4 into maplibre:main Dec 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Globe with/without terrain can zoom too far out Mesh is broken near the pole on globe with terrain
2 participants